Skip to content

Conversation

@vaind
Copy link
Collaborator

@vaind vaind commented Jun 12, 2023

Removes use of client.Options() from the internal code to avoid copying the options object.

#skip-changelog

@vaind vaind force-pushed the refactor/access-options-directly branch from 120717e to f022537 Compare June 12, 2023 15:18
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 97.50% and project coverage change: +0.16 🎉

Comparison is base (4a965bc) 80.49% compared to head (f022537) 80.65%.

❗ Current head f022537 differs from pull request most recent head bb82078. Consider uploading reports for the commit bb82078 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   80.49%   80.65%   +0.16%     
==========================================
  Files          42       43       +1     
  Lines        4327     4332       +5     
==========================================
+ Hits         3483     3494      +11     
+ Misses        716      712       -4     
+ Partials      128      126       -2     
Impacted Files Coverage Δ
client.go 87.04% <96.87%> (-0.05%) ⬇️
dynamic_sampling_context.go 93.24% <100.00%> (-0.18%) ⬇️
hub.go 87.23% <100.00%> (-0.07%) ⬇️
integrations.go 89.01% <100.00%> (ø)
interfaces.go 92.57% <100.00%> (ø)
span_recorder.go 89.65% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Michi Hoffmann <[email protected]>
@cleptric
Copy link
Member

Let me get you merge access, brb 🙂

@vaind vaind merged commit 97a00a4 into getsentry:master Jun 12, 2023
@vaind vaind deleted the refactor/access-options-directly branch June 12, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants