Attachments can be manipulated via hints - Extra for attachment methods directly on Hints #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Attachments can be manipulated via hints - Extra for attachment methods directly on Hints ([#2049](https://github.com/getsentry/sentry-java/pull/2049))If none of the above apply, you can opt out of this check by adding |
4 tasks
Codecov Report
@@ Coverage Diff @@
## feat/allow-attachment-manipulation-via-hints #2049 +/- ##
===============================================================================
Coverage ? 80.96%
Complexity ? 3177
===============================================================================
Files ? 229
Lines ? 11707
Branches ? 1556
===============================================================================
Hits ? 9479
Misses ? 1646
Partials ? 582 Continue to review full report at Codecov.
|
4 tasks
bruno-garcia
approved these changes
May 16, 2022
| } | ||
|
|
||
| public void clearAttachments() { | ||
| internalStorage.put(SENTRY_ATTACHMENTS, new CopyOnWriteArrayList<Attachment>()); |
There was a problem hiding this comment.
this could be a list instead
|
Decided to go with list property in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Extra for #2046 with attachment methods directly in
Hintsinstead of a separateAttachmentsobject.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps