Skip to content

Remove reportFullDisplayed #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sentry/api/sentry.api
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,6 @@ public abstract interface class io/sentry/IScopes {
public abstract fun pushScope ()Lio/sentry/ISentryLifecycleToken;
public abstract fun removeExtra (Ljava/lang/String;)V
public abstract fun removeTag (Ljava/lang/String;)V
public fun reportFullDisplayed ()V
public abstract fun reportFullyDisplayed ()V
public abstract fun setActiveSpan (Lio/sentry/ISpan;)V
public abstract fun setExtra (Ljava/lang/String;Ljava/lang/String;)V
Expand Down Expand Up @@ -2370,7 +2369,6 @@ public final class io/sentry/Sentry {
public static fun pushScope ()Lio/sentry/ISentryLifecycleToken;
public static fun removeExtra (Ljava/lang/String;)V
public static fun removeTag (Ljava/lang/String;)V
public static fun reportFullDisplayed ()V
public static fun reportFullyDisplayed ()V
public static fun setCurrentHub (Lio/sentry/IHub;)Lio/sentry/ISentryLifecycleToken;
public static fun setCurrentScopes (Lio/sentry/IScopes;)Lio/sentry/ISentryLifecycleToken;
Expand Down
8 changes: 0 additions & 8 deletions sentry/src/main/java/io/sentry/IScopes.java
Original file line number Diff line number Diff line change
Expand Up @@ -657,14 +657,6 @@ void setSpanContext(
*/
void reportFullyDisplayed();

/**
* @deprecated See {@link IScopes#reportFullyDisplayed()}.
*/
@Deprecated
default void reportFullDisplayed() {
reportFullyDisplayed();
}

/**
* Continue a trace based on HTTP header values. If no "sentry-trace" header is provided a random
* trace ID and span ID is created.
Expand Down
9 changes: 0 additions & 9 deletions sentry/src/main/java/io/sentry/Sentry.java
Original file line number Diff line number Diff line change
Expand Up @@ -1085,15 +1085,6 @@ public static void reportFullyDisplayed() {
getCurrentScopes().reportFullyDisplayed();
}

/**
* @deprecated See {@link Sentry#reportFullyDisplayed()}.
*/
@Deprecated
@SuppressWarnings("InlineMeSuggester")
public static void reportFullDisplayed() {
reportFullyDisplayed();
}

/** the metrics API for the current Scopes */
@NotNull
@ApiStatus.Experimental
Expand Down
7 changes: 0 additions & 7 deletions sentry/src/test/java/io/sentry/ScopesTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -1975,13 +1975,6 @@ class ScopesTest {
assertTrue(called)
}

@Test
fun `reportFullDisplayed calls reportFullyDisplayed`() {
val scopes = spy(generateScopes())
scopes.reportFullDisplayed()
verify(scopes).reportFullyDisplayed()
}

@Test
fun `continueTrace creates propagation context from headers and returns transaction context if performance enabled`() {
val scopes = generateScopes()
Expand Down
11 changes: 0 additions & 11 deletions sentry/src/test/java/io/sentry/SentryTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -714,17 +714,6 @@ class SentryTest {
verify(scopes).reportFullyDisplayed()
}

@Test
fun `reportFullDisplayed calls reportFullyDisplayed`() {
val scopes = mock<IScopes>()
Sentry.init {
it.dsn = dsn
}
Sentry.setCurrentScopes(scopes)
Sentry.reportFullDisplayed()
verify(scopes).reportFullyDisplayed()
}

@Test
fun `ignores executorService if it is closed`() {
var sentryOptions: SentryOptions? = null
Expand Down
Loading