POTEL 68 - Add SentryOpenTelemetryMode.OFF
#3995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 68 - Add `SentryOpenTelemetryMode.OFF` ([#3995](https://github.com/getsentry/sentry-java/pull/3995))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20d57f2 | 437.12 ms | 511.13 ms | 74.00 ms |
| 00de25b | 401.31 ms | 417.12 ms | 15.81 ms |
| b3cddf5 | 415.88 ms | 477.86 ms | 61.99 ms |
| b4a5c82 | 435.04 ms | 490.67 ms | 55.63 ms |
| de275f3 | 393.22 ms | 453.75 ms | 60.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20d57f2 | 1.65 MiB | 2.31 MiB | 677.05 KiB |
| 00de25b | 1.65 MiB | 2.31 MiB | 677.07 KiB |
| b3cddf5 | 1.65 MiB | 2.31 MiB | 677.05 KiB |
| b4a5c82 | 1.65 MiB | 2.31 MiB | 677.05 KiB |
| de275f3 | 1.65 MiB | 2.31 MiB | 677.05 KiB |
…the ScopesStorage is initialized
adinauer
commented
Dec 19, 2024
| if (SentryOpenTelemetryMode.OFF == options.getOpenTelemetryMode()) { | ||
| options.setSpanFactory(new DefaultSpanFactory()); | ||
| // } else { | ||
| // enabling this causes issues with agentless where OTel spans seem to be randomly ended |
There was a problem hiding this comment.
We have to keep using SpanFactoryFactory in the SentryOptions ctor for now as setting the OtelSpanFactory here causes OpenTelemetry spans to be ended in the agentless sample.
I haven't investigated yet why that's happening.
There was a problem hiding this comment.
Hmm, let's keep this for now and maybe create a separate issue to investigate
lbloder
reviewed
Dec 20, 2024
| if (SentryOpenTelemetryMode.OFF == options.getOpenTelemetryMode()) { | ||
| options.setSpanFactory(new DefaultSpanFactory()); | ||
| // } else { | ||
| // enabling this causes issues with agentless where OTel spans seem to be randomly ended |
There was a problem hiding this comment.
Hmm, let's keep this for now and maybe create a separate issue to investigate
| OpenTelemetryUtil.applyIgnoredSpanOrigins(options, new LoadClass()); | ||
| } | ||
|
|
||
| @SuppressWarnings("UnusedMethod") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
SentryOpenTelemetryMode.OFF💡 Motivation and Context
Allows customers to completely disable usage of OpenTelemetry by Sentry, even if it is present.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps