Skip to content

Add MANIFEST.MF to Sentry JARs #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 27, 2025
Merged

Add MANIFEST.MF to Sentry JARs #4272

merged 13 commits into from
Mar 27, 2025

Conversation

adinauer
Copy link
Member

📜 Description

Add MANIFEST.MF to Sentry JARs

Sample content:

Manifest-Version: 1.0
Sentry-Version-Name: 8.4.0
Sentry-SDK-Name: sentry.java.opentelemetry.agentless-spring
Sentry-SDK-Package-Name: maven:io.sentry:sentry-opentelemetry-agentless-
 spring
Implementation-Vendor: Sentry
Implementation-Title: sentry-opentelemetry-agentless-spring
Implementation-Version: 8.4.0

💡 Motivation and Context

Closes #4189 and is also needed for #4132

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 09e4c32

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.90 ms 438.65 ms 36.75 ms
Size 1.58 MiB 2.22 MiB 653.17 KiB

Previous results on branch: feat/manifest-for-jars

Startup times

Revision Plain With Sentry Diff
2381e8d 422.20 ms 459.94 ms 37.74 ms
585dd17 420.44 ms 473.23 ms 52.79 ms

App size

Revision Plain With Sentry Diff
2381e8d 1.58 MiB 2.21 MiB 647.55 KiB
585dd17 1.58 MiB 2.22 MiB 653.29 KiB

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/RateLimiter.java

Base automatically changed from feat/noop-on-mixed-versions-android to main March 27, 2025 11:14
@adinauer adinauer merged commit 10dfe0c into main Mar 27, 2025
35 checks passed
@adinauer adinauer deleted the feat/manifest-for-jars branch March 27, 2025 11:47
@melloware
Copy link

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Package Version Information in MANIFEST.MF
4 participants