Skip to content

fix(breadcrumbs): Improve low memory breadcrumb capturing #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 9, 2025

📜 Description

  • onLowMemory is a deprecated API and should not be used in conjunction with onTrimMemory
    image

  • Move the level check out of the runnable lambda, so we don't even enqueue a task if the level is not suitable for reporting

  • Debounce low memory breadcrumbs by minute

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 712.40 ms 822.58 ms 110.18 ms
Size 1.58 MiB 2.08 MiB 505.66 KiB

Previous results on branch: rz/fix/low-memory-breadcrumbs

Startup times

Revision Plain With Sentry Diff
1acc81a 404.24 ms 423.20 ms 18.95 ms

App size

Revision Plain With Sentry Diff
1acc81a 1.58 MiB 2.08 MiB 505.29 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn enabled auto-merge (squash) April 10, 2025 08:35
@romtsn romtsn merged commit df386ef into main Apr 10, 2025
35 checks passed
@romtsn romtsn deleted the rz/fix/low-memory-breadcrumbs branch April 10, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants