perf(user-interactions): Make user interaction tracing faster and allocate less #4347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
class.getName
instead ofclass.getCanonicalName
as it's almost ~2x faster, and there's almost no difference in what it returns except for inner classes (tested 10k iterations over 10 times)Fix
SentryTag
extraction for compose, becauseSentryTagModifierNodeElement
is an inner class and we have to use a dollar-sign to properly get its class name.Use
fori
instead offoreach
loop to avoid allocating an Iterator in hot paths (e.g. when traversing the view hierarchy which can happen 100s of times for complex UIs). Reduced allocations by almost 2x doing the same user flow (launch -> scroll -> button click)Before
After
💡 Motivation and Context
Improve perf of user interaction tracing
💚 How did you test it?
existing tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps