fix(replay): Use global visible rect when text layout is not laid out in Compose #4361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
When a
Text
component does not specify any font parameters (like fontSize, etc.), the underlyingTextLayout
returns bogus values. So we're checking now if the fontSize != Unspecified (though there may be some other indicators we'd need to use in the future), and if it is we fallback to just masking by global visible bounds.Before
After
💡 Motivation and Context
Probably part of #4177
💚 How did you test it?
manually + automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps