Send UI Profiling app start chunk when it finishes #4423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanosiano
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
Contributor
Performance metrics 🚀
|
romtsn
reviewed
May 20, 2025
| Sentry.getCurrentScopes().getOptions().getCompositePerformanceCollector(); | ||
| final @Nullable RateLimiter rateLimiter = scopes.getRateLimiter(); | ||
| if (rateLimiter != null) { | ||
| rateLimiter.addRateLimitObserver(this); |
Member
There was a problem hiding this comment.
can this be potentially added multiple times now?
Contributor
Author
There was a problem hiding this comment.
it checks for scopes == null, so it should never occur more than once
romtsn
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
init the scopes at profile finish, too, so that it sends the chunk the first time
💡 Motivation and Context
When the startOnAppStart option is used, the first chunk is started when the SDK is not enabled, so it's stored in memory.
The SDK reevaluates the scopes when the next chunk is started, and in the meantime it keeps the chunks in memory until the second chunk finishes.
This is not an issue normally, as it affects only the very first chunk when using the startProfilerOnAppStart option.
But we do it in the UI tests of our demo app, which doesn't send any chunk unless another transaction is started one minute after the app start.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps