Skip to content

Remove clean before test #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

Remove clean before test #4476

merged 3 commits into from
Jun 19, 2025

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented Jun 6, 2025

📜 Description

This removes the redundant dependency on cleanTest from each test task. This still allows the test to come from the cache so it doesn't really make sense.
Also add build caching for spotless format execution
#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add build caching for spotless format execution
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.98 ms 448.61 ms 46.63 ms
Size 1.58 MiB 2.09 MiB 518.66 KiB

Previous results on branch: no/optimize

Startup times

Revision Plain With Sentry Diff
d67bd0b 439.06 ms 507.98 ms 68.92 ms
7908017 451.30 ms 520.00 ms 68.70 ms

App size

Revision Plain With Sentry Diff
d67bd0b 1.58 MiB 2.09 MiB 518.67 KiB
7908017 1.58 MiB 2.08 MiB 511.07 KiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw you opened the issue in gradle about it years ago :D

@runningcode
Copy link
Contributor Author

Ah yeah, the one about having a hermetic testing environment? Still hasn’t become a thing unfortunately.

@runningcode runningcode merged commit 8ffe8f0 into main Jun 19, 2025
34 of 35 checks passed
@runningcode runningcode deleted the no/optimize branch June 19, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants