Skip to content

Serialize preContext and postContext in SentryStackFrame #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 10, 2025

📜 Description

Serializes and deserializes the preContext and postContext fields in SentryStackFrame.
They don't seem to be used anywhere in the SDK, so perhaps that's why they were ignored before.

💡 Motivation and Context

Closes #4479

💚 How did you test it?

Updated existing test.

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 10, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.53 ms 432.71 ms 31.18 ms
Size 1.58 MiB 2.12 MiB 548.76 KiB

Previous results on branch: lcian/feat/serialize-frame-context

Startup times

Revision Plain With Sentry Diff
843440a 444.15 ms 513.04 ms 68.89 ms

App size

Revision Plain With Sentry Diff
843440a 1.58 MiB 2.08 MiB 511.19 KiB

@lcian lcian marked this pull request as ready for review June 10, 2025 12:30
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can we please add a changelog entry? Got bitten a few times where we didn't mention things and I was looking for them

@lcian
Copy link
Member Author

lcian commented Jun 16, 2025

lgtm, but can we please add a changelog entry? Got bitten a few times where we didn't mention things and I was looking for them

Thanks, sure, adding it!

@lcian lcian merged commit e56c1d1 into main Jun 16, 2025
34 checks passed
@lcian lcian deleted the lcian/feat/serialize-frame-context branch June 16, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryStackFrame not serializing/deserializing preContext & postContext
2 participants