-
-
Notifications
You must be signed in to change notification settings - Fork 455
SDKs send queue is no longer shutdown immediately on re-init #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/e2e-tests-console-otel
Are you sure you want to change the base?
SDKs send queue is no longer shutdown immediately on re-init #4564
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- SDKs send queue is no longer shutdown immediately on re-init ([#4564](https://github.com/getsentry/sentry-java/pull/4564)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
...sole-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt
Outdated
Show resolved
Hide resolved
…c/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📜 Description
SDKs send queue is no longer shutdown immediately on re-init
💡 Motivation and Context
When re-initializing the SDK, we were:
This caused events to be lost in case of re-init, which is common in e.g. Spring Boot + Logback setups.
After the change we are:
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps