Skip to content

Commit d5978f4

Browse files
rhcarvalhoonurtemizkan
authored andcommitted
ci: Re-enable part of @sentry/browser integration tests (#4226)
The integration tests still work, independent of running them on multiple browsers through BrowserStack. This change re-enables part of the old "BrowserStack" job, without the BrowserStack-dependant part. It is unclear why we disabled everything at once, seems like an oversight.
1 parent 4d177e2 commit d5978f4

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -268,15 +268,12 @@ jobs:
268268
${{ github.workspace }}/packages/**/*.tgz
269269
${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip
270270
271-
job_browserstack_test:
272-
name: BrowserStack
271+
job_browser_integration_tests:
272+
name: Browser Integration Tests
273273
needs: job_build
274274
runs-on: ubuntu-latest
275-
timeout-minutes: 45
275+
timeout-minutes: 15
276276
continue-on-error: true
277-
# TODO: Fix BrowserStack tests
278-
# if: startsWith(github.ref, 'refs/heads/release/')
279-
if: false
280277
steps:
281278
- name: Check out current commit (${{ github.sha }})
282279
uses: actions/checkout@v2
@@ -293,11 +290,7 @@ jobs:
293290
path: ${{ env.CACHED_BUILD_PATHS }}
294291
key: ${{ env.BUILD_CACHE_KEY }}
295292
- name: Run integration tests
296-
env:
297-
BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
298-
BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
299293
run: |
300294
cd packages/browser
301-
yarn test:integration:checkbrowsers
302295
yarn test:integration
303296
yarn test:package

0 commit comments

Comments
 (0)