Re-enable part of @sentry/browser integration tests #4226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests still work, independent of running them on multiple browsers through BrowserStack. This change re-enables part of the old "BrowserStack" job, without the BrowserStack-dependant part. It is unclear why we disabled everything at once, seems like an oversight.
rhcarvalho
requested review from
a team,
AbhiPrasad and
iker-barriocanal
and removed request for
a team
size-limit report
|
iker-barriocanal
approved these changes
Dec 3, 2021
|
Ignoring the ember test failure that is being worked on by the team independent of this PR. |
|
For future reference: I've noticed this low-hanging fruit while reviewing #3989 and trying to understand what was the state of the existing |
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
The integration tests still work, independent of running them on multiple browsers through BrowserStack. This change re-enables part of the old "BrowserStack" job, without the BrowserStack-dependant part. It is unclear why we disabled everything at once, seems like an oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests still work, independent of running them on multiple browsers through BrowserStack.
This change re-enables part of the old "BrowserStack" job, without the BrowserStack-dependant part.
It is unclear why we disabled everything at once, seems like an oversight. The tests were disabled in #3199.