Skip to content

[v9] Add v8 suffix to lambda layer in .craft.yml on v8 branch #14842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreiborza opened this issue Dec 27, 2024 · 1 comment · Fixed by #15351
Closed

[v9] Add v8 suffix to lambda layer in .craft.yml on v8 branch #14842

andreiborza opened this issue Dec 27, 2024 · 1 comment · Fixed by #15351
Assignees

Comments

@andreiborza
Copy link
Member

andreiborza commented Dec 27, 2024

Description

We had to remove the suffix for now as it breaks the aws integration setup:

https://github.com/getsentry/sentry/blob/c11f4c099257b2388d150f71fb39516e3d3f2328/src/sentry/integrations/aws_lambda/utils.py#L236-L253

The v8 suffixed layer ends up in the release registry (with a lower version number) so the integration assumes we are setting up an older version of the @sentry/serverless sdk.

andreiborza added a commit that referenced this issue Dec 27, 2024
The v8 suffixed layer lands in the release-registry every time we
publish a release from the v8 branch which not only breaks
https://github.com/getsentry/sentry/blob/c11f4c099257b2388d150f71fb39516e3d3f2328/src/sentry/integrations/aws_lambda/utils.py#L236-L253
but also ends up in the docs as the current version: when using the ARN
dropdown
https://docs.sentry.io/platforms/javascript/guides/aws-lambda/install/cjs-layer/.

This removes the suffix so we get the current major published under the
non-suffixed name.

Follow-up task:
#14842
@andreiborza andreiborza self-assigned this Jan 27, 2025
andreiborza added a commit that referenced this issue Feb 10, 2025
…#15351)

With the upcoming release of Sentry v9, we will stop publishing the AWS
Lambda layer under `SentryNodeServerlessSDK` and instead use a version
suffixed naming scheme.

We now have:
- `SentryNodeServerlessSDKv7`
- `SentryNodeServerlessSDKv8`
- `SentryNodeServerlessSDKv9`

If you're expecting to get updates for your v8 layer, please switch over
to `SentryNodeServerlessSDKv8` otherwise upgrade to
`SentryNodeServerlessSDKv9`.

Closes: #14842
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #15351, which was included in the 8.55.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant