Skip to content

[Node] Add maxRequestBodySize to SentryHttpIntegration #16179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
s1gr1d opened this issue Apr 30, 2025 · 1 comment · Fixed by #16225
Closed

[Node] Add maxRequestBodySize to SentryHttpIntegration #16179

s1gr1d opened this issue Apr 30, 2025 · 1 comment · Fixed by #16225
Assignees
@s1gr1d
Labels
Improvement Node.js

Comments

@s1gr1d
Copy link
Member

s1gr1d commented Apr 30, 2025

Description

Adding the option to limit the body size like described here: https://develop.sentry.dev/sdk/expected-features/#attaching-request-body-in-server-sdks

This should also be documented in "Data Collected": https://docs.sentry.io/platforms/javascript/data-management/data-collected/
@s1gr1d s1gr1d added Node.js Package: node Issues related to the Sentry Node SDK Improvement labels Apr 30, 2025
@AbhiPrasad AbhiPrasad changed the title [Node] Add maxRequestBodySize to SentryHtttpIntegration [Node] Add maxRequestBodySize to SentryHttpIntegration May 1, 2025
@s1gr1d s1gr1d self-assigned this May 5, 2025
@stephanie-anderson stephanie-anderson removed the Package: node Issues related to the Sentry Node SDK label May 7, 2025
@s1gr1d s1gr1d mentioned this issue May 7, 2025
Merged
s1gr1d added a commit that referenced this issue May 15, 2025
@s1gr1d
feat(node): Add maxIncomingRequestBodySize (#16225)
12c90d1 
Adds `maxIncomingRequestBodySize` to the Node `httpIntegration`.
The setting controls the maximum size of HTTP request bodies attached to
events.

There is the option `maxRequestBodySize`
([docs](https://develop.sentry.dev/sdk/expected-features/#attaching-request-body-in-server-sdks))
in other SDKs, but to be more specific, this is named with `incoming`.

Available options:
- 'none': No request bodies will be attached
- 'small': Request bodies up to 1,000 bytes will be attached
- 'medium': Request bodies up to 10,000 bytes will be attached (default)
- 'always': Request bodies will always be attached (up to 1 MB)

closes #16179
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16225, which was included in the 9.20.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1gr1d s1gr1d

Labels
Improvement Node.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): Add maxIncomingRequestBodySize getsentry/sentry-javascript
2 participants
@stephanie-anderson @s1gr1d