-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Avoid hardcoding GitHub tarball URLs in dependencies β breaks private registry workflows #16311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, thanks for raising this. We are on this and will change this to avoid the tarball in dependencies! cc @andreiborza See: #16309 |
Hi @YashAggarwal21, thank you for taking the time to write such detailed and well written issue! This change has caused a bunch of problems, sorry for that :(. We're working on vendoring the package in which will hopefully resolve that issue. I'm wondering if you can get around this issue for now by adding a resolutions entry to your npm "overrides": {
"@fastify/otel": "getsentry/fastify-otel#otel-v1"
} yarn "resolutions": {
"@fastify/otel": "getsentry/fastify-otel#otel-v1"
} pnpm "pnpm": {
"overrides": {
"@fastify/otel": "getsentry/fastify-otel#otel-v1"
}
} |
We're affected by this issue but unfortunately that wouldn't fix it for us either as it'd have a dependency on cloning the fork from Github, and we don't allow access to that (just a proxy to the npm registry). Vendoring seems like the best solution here so we are left with pinning to old versions until this is implemented. |
Problem Statement
Hi Sentry team π,
Weβre running into issues due to a dependency introduced in
@sentry/[email protected]
which references a GitHub tarball directly:Reference PR - #16287
This causes real problems in environments like ours, where only private registries (e.g., AWS CodeArtifact) are allowed for security and compliance reasons.
Problem
Since this dependency is declared as a tarball URL:
npm
andyarn
bypass.npmrc
registry settings.package-lock.json
, triggering CI validation errors like:@fastify/[email protected]
exists there.overrides
orresolutions
, which weβd prefer to avoid.Solution Brainstorm
Expected Behavior
Weβd like to see Sentry declare the dependency as a semver range like:
This:
.npmrc
and private registries.@fastify/[email protected]
in your lockfile).Why This Matters
Many regulated environments prohibit installing packages from arbitrary URLs. Package managers like
npm
andyarn
are designed to route semver-based dependencies through controlled registries, which allows:Hardcoded tarball URLs break that model.
Ask
Would you consider:
@fastify/otel
^0.8.0
)@fastify/otel
to npm under the Sentry organization and referencing thatThis small change would make Sentry easier to adopt in enterprise environments.
Thank you for the great work on the SDK!
The text was updated successfully, but these errors were encountered: