fix(node): Pin @fastify/otel fork to direct url to allow installing without git
#16287
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without git The previous approach breaks systems that don't have git installed (e.g. slim linux distros).
chargome
approved these changes
May 14, 2025
chargome
approved these changes
May 14, 2025
packages/node/package.json
Outdated
| @@ -65,7 +65,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "@fastify/otel": "getsentry/fastify-otel#otel-v1", | |||
| "@fastify/otel": "https://codeload.github.com/getsentry/fastify-otel/tar.gz/d6bb1756c3db3d00d4d82c39c93ee3316e06d305", | |||
There was a problem hiding this comment.
as discussed we need to keep this up-to date whenever we push updates to this fork
There was a problem hiding this comment.
I added a warning to the fork readme: https://github.com/getsentry/fastify-otel/tree/otel-v1
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach of specifying the git repo directly breaks systems that don't have git installed (e.g. slim linux distros). I tested this works on a ubuntu vm without git.
Important: When making changes to the fork, the linked commit sha in
packages/node/package.jsonhas to be updated and the yarn lockfile regenerated.Resolves: #16281