Minified files should use C-Style comments on last line

[jpw]

Right now the minified files look like;

/*! Raven.js 1.1.16 (2cf8531) | github.com/getsentry/raven-js */
!function(a,b){"use strict";function c(a,b)...
//# sourceMappingURL=raven.min.map

I'm downloading these minified files and concatenating them using Grunt with all my other vendor JS files.

As other libs typically begin with C-Style comments the concatenated output looks like;

};/*! Raven.js 1.1.16 (2cf8531) | github.com/getsentry/raven-js */
!function(a,b){"use strict";function c(a,b)...
//# sourceMappingURL=raven.min.map;/**
 * A class to parse color values
 ...

...which throws a "Unexpected token: operator (*). " because the inline commenting comments out the beginning of the following C-Style comment block in the following library.

[skovhus]

This is a non issue. The convention for the sourceMappingURL line is that it starts with single line comment (e.g. //). Example http://backbonejs.org/backbone-min.js

Take a look here https://github.com/gruntjs/grunt-contrib-concat

Hope it works for you.

[skovhus]

@mattrobenolt I think we should close this.

[mattrobenolt]

@jpw Yeah, you should just be concatenating with a newline. And really, if you're concatenating our minified JS, the source map declaration doesn't even make sense.