Cannot convert undefined or null to object in Chrome v74

[martinsaposnic]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

https://sentry.io/organizations/the-dotcom-u0/issues/2334549076/?project=1880120&query=is%3Aunresolved

Package + Version

• @sentry/browser

Version:

6.2.5

Description

Happening in Chrome version 74.0.3729.0

Getting this error: Cannot convert undefined or null to object

It seems that this issue should be reopened #2074 and this PR #3208 doesn't solve this issue

[kamilogorek]

This is indicated as the error coming from the Sentry, as we are wrapping rAF API to get some useful data (eg. function name, but in your case, it's not helpful, as you are using anonymous callbacks).

The error is produced when calling the original requestAnimationFrame handler, which means that it comes from decorateHandler, wait-for or detectElementResize. I'd first check detectElementResize, as it's easy to lose a reference to dom element/object when you are not cleaning up rAF calls.

This error is usually produced by Object.keys or Object.assign calls.

Hope that helps to dig into the issue more. Cheers!

[iulo]

@kamilogorek Hi bro, does this issue is same as #2074 ?

I saw @martinsaposnic use v6.2.5, but still got this error.

And @NateScarlet reference a link which provide a solution, is it appropriate ?

const isAffectByIssue3388 = navigator.userAgent.includes('Chrome/74.0.3729')
new sentry.Integrations.TryCatch({
   requestAnimationFrame: !isAffectByIssue3388,
}),

[kamilogorek]

Yes, this would be correct:

const isAffectByIssue3388 = navigator.userAgent.includes('Chrome/74.0.3729')
Sentry.init({
  integrations: [new Sentry.Integrations.TryCatch({
   requestAnimationFrame: !isAffectByIssue3388,
  })]
});

[iulo]

Tks bro. I use this, should have better compatibility, no need rewrite all default integrations

const isAffectByIssue3388 = navigator.userAgent.includes('Chrome/74.0.3729')

Sentry.init({
  integrations: function(integrations) {
    const newIntegrations = integrations.map((integration) => {
      if (integration.name === 'TryCatch') {
        return new Sentry.Integrations.TryCatch({
          requestAnimationFrame: !isAffectByIssue3388 // disable raf hook
        })
      }

      return integration
    })
    return newIntegrations
  }
})

[kamilogorek]

It won't rewrite them. We are doing a smart-merge, so only TryCatch will be overritten. My code is effectively the same as yours :)

[iulo]

Oh ok, thanks for providing this info

[NateScarlet]

event target wrap is also affected, is this same as #2074 ?

[kamilogorek]

Every instrumentation that eventually calls native function can be reported like this. It's very rare occurrence, but it can happen.

[Fonger]

We have the same issues. However, not everyone uses chrome 74.0.3729. Some android app (like Facebook) is using their own Facebook user-agent, but the underlying browser is system webview, which may be chrome 74. We can't fully apply workaround for these users by detecting user-agent. Hope this can be fixed.

[qtiki]

We're also seeing this. Are there plans to implement the proposed workaround in Sentry SDK or does everybody need to copy&paste the fix from here?

[chuanxiaojin]

We have the same issues. However, not everyone uses chrome 74.0.3729. Some android app (like Facebook) is using their own Facebook user-agent, but the underlying browser is system webview, which may be chrome 74. We can't fully apply workaround for these users by detecting user-agent. Hope this can be fixed.

@Fonger hello, How did you finally solve it?

[Fonger]

We have the same issues. However, not everyone uses chrome 74.0.3729. Some android app (like Facebook) is using their own Facebook user-agent, but the underlying browser is system webview, which may be chrome 74. We can't fully apply workaround for these users by detecting user-agent. Hope this can be fixed.

@Fonger hello, How did you finally solve it?

Sadly we didn't solve it. I just apply the Chrome 74 user-agent workaround and ignore the minority of the affected users.

[chuanxiaojin]

We have the same issues. However, not everyone uses chrome 74.0.3729. Some android app (like Facebook) is using their own Facebook user-agent, but the underlying browser is system webview, which may be chrome 74. We can't fully apply workaround for these users by detecting user-agent. Hope this can be fixed.

@Fonger hello, How did you finally solve it?

Sadly we didn't solve it. I just apply the Chrome 74 user-agent workaround and ignore the minority of the affected users.

ok, thanks.