Skip to content

Do not set stacktrace if there are no frames #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marandaneto opened this issue Aug 19, 2021 · 6 comments · Fixed by #4614
Closed

Do not set stacktrace if there are no frames #4418

marandaneto opened this issue Aug 19, 2021 · 6 comments · Fixed by #4614
Assignees

Comments

@marandaneto
Copy link

marandaneto commented Aug 19, 2021

e.g.:

{
  "exception": {
    "values": [
      {
        "type": "Error",
        "value": "TypeError: undefined is not a function, js engine: hermes",
        "stacktrace": {
          "frames": null
        },
        "mechanism": {
          "type": "generic",
          "synthetic": true,
          "handled": true
        }
      }
    ]
  }
}

The UI will show an error because of that.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@marandaneto marandaneto reopened this Nov 12, 2021
@marandaneto
Copy link
Author

marandaneto commented Jan 19, 2022

Checking with the Web team if they can take it since the change is likely on the JS SDK.
Edit: Web Team will take it.

@marandaneto marandaneto transferred this issue from getsentry/sentry-react-native Jan 19, 2022
@AbhiPrasad
Copy link
Member

This may be fixed with #4555, @timfish could you double check for us?

@timfish
Copy link
Collaborator

timfish commented Feb 18, 2022

I will check!

I think I might have left it as it was while refactoring.

@timfish
Copy link
Collaborator

timfish commented Feb 18, 2022

It looks like my changes can result in an empty array for stacktrace.frames.

The developer docs say that it should only be set if there is 1 or more frames so I'll fix this!

@AbhiPrasad AbhiPrasad self-assigned this Feb 18, 2022
@timfish
Copy link
Collaborator

timfish commented Feb 21, 2022

This PR contains a fix for this issue for node.js.

I'll do another PR to fix this for the browser SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants