Skip to content

Improve NextJS integration tests #6053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 5 tasks
AbhiPrasad opened this issue Oct 26, 2022 · 3 comments
Closed
2 of 5 tasks

Improve NextJS integration tests #6053

AbhiPrasad opened this issue Oct 26, 2022 · 3 comments
Assignees
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK Type: Improvement Type: Tests

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Oct 26, 2022

Problem Statement

NextJS integration tests are definitely our most flaky set of tests, and they are also much harder to debug since they don't use jest under the hood.

https://sentry.io/organizations/sentry/dashboard/24245/?project=5899451&statsPeriod=3d

image

image

We should update these tests!

Solution Brainstorm

These probably involves a couple of changes:

@lobsterkatie
Copy link
Member

Before we move more tests to playwright, I'd like us to spend some time figuring out how to debug them in VSCode. I've tried, but have yet to make it work successfully.

@onurtemizkan
Copy link
Collaborator

Before we move more tests to playwright, I'd like us to spend some time figuring out how to debug them in VSCode. I've tried, but have yet to make it work successfully.

@lobsterkatie - After several failed attempts with launch.json, I was able to debug Next client-side tests using https://github.com/microsoft/playwright-vscode extension. It's not perfect though, for example, it doesn't fully support webServer config in playwright.config.ts. I'll continue trying to figure out how to make it work with launch.json. But we have a working alternative for the time being.

@HazAT
Copy link
Member

HazAT commented Feb 13, 2023

Closing in favor of #6906

@HazAT HazAT closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK Type: Improvement Type: Tests
Projects
None yet
Development

No branches or pull requests

4 participants