-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use playwright instead of puppeteer in @sentry/wasm
tests
#6054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
would be interested if we have a goal to get rid of pupeteer all together, to have one parent issue listing the remaining using pupeteer to checklist them off |
With this and #6053 (in progress), we should be getting rid of puppeteer across the board. Only references to puppeteer in the codebase are in the nextjs and wasm packages. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
just tested freshly cloning and initializing the repo after #7048 was merged. Seems like in the new Puppeteer version, installing chromium works again on M1 and If I get to it this week, I'll try to replace puppeteer with PW and else I think it's fair to close this issue. |
Problem Statement
We use playwright for our Remix and browser integration tests (and we should also do it for our NextJS ones as well), but we don't use it for our
@sentry/wasm
integration tests.Solution Brainstorm
Remove puppeteer and use playwright. Removing the dependency reduces dependencies we rely on, which should speed up CI, and make debugging easier across the board.
The text was updated successfully, but these errors were encountered: