Skip to content

Use playwright instead of puppeteer in @sentry/wasm tests #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbhiPrasad opened this issue Oct 26, 2022 · 4 comments · Fixed by #7217
Closed

Use playwright instead of puppeteer in @sentry/wasm tests #6054

AbhiPrasad opened this issue Oct 26, 2022 · 4 comments · Fixed by #7217

Comments

@AbhiPrasad
Copy link
Member

Problem Statement

We use playwright for our Remix and browser integration tests (and we should also do it for our NextJS ones as well), but we don't use it for our @sentry/wasm integration tests.

Solution Brainstorm

Remove puppeteer and use playwright. Removing the dependency reduces dependencies we rely on, which should speed up CI, and make debugging easier across the board.

@smeubank
Copy link
Member

would be interested if we have a goal to get rid of pupeteer all together, to have one parent issue listing the remaining using pupeteer to checklist them off

@AbhiPrasad
Copy link
Member Author

With this and #6053 (in progress), we should be getting rid of puppeteer across the board.

image

Only references to puppeteer in the codebase are in the nextjs and wasm packages.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@Lms24
Copy link
Member

Lms24 commented Feb 13, 2023

just tested freshly cloning and initializing the repo after #7048 was merged. Seems like in the new Puppeteer version, installing chromium works again on M1 and PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true yarn isn't necessary anymore.

If I get to it this week, I'll try to replace puppeteer with PW and else I think it's fair to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants