Skip to content

The CLS metrics report does not follow options.metricOptions.reportAllChanges #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
ys-zhifu opened this issue Oct 28, 2022 · 6 comments · Fixed by #6456
Closed
3 tasks done

The CLS metrics report does not follow options.metricOptions.reportAllChanges #6078

ys-zhifu opened this issue Oct 28, 2022 · 6 comments · Fixed by #6456
Assignees

Comments

@ys-zhifu
Copy link

Is there an existing issue for this?

How do you use Sentry?

Self-hosted/on-premise

Which package are you using?

@sentry/vue

SDK Version

7.16.0

Framework Version

vue 3.2.33

Link to Sentry event

No response

Steps to Reproduce

  1. sentry init
  2. Check the reported transaction data and find that the CLS metrics is missing
  3. After reading the code, I found that only when the page is hidden can I report
  4. This reportAllChanges seems meaningless

image

The following is the code for reporting CLS

image
image
image

Expected Result

CLS metrics data reporting

Actual Result

CLS metrics data not reporting

@AbhiPrasad
Copy link
Member

Hey! This is intentional behaviour, as we generally don't want to users to report intermediate values as they are less accurate. LCP was put in here while we were testing improving this generally. @k-fish should we remove the reportAllChanges option?

@k-fish
Copy link
Member

k-fish commented Oct 28, 2022

@AbhiPrasad yeah, now that idleTimeout is fixed and there is some measure of control over when a transaction ends users shouldn't be seeing as missing as many LCP. Users that were using it may need to bump idleTimeout if they find their counts of LCP measurements count down, though.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@timfish
Copy link
Collaborator

timfish commented Dec 3, 2022

@k-fish should we be removing the reportAllChanges option?

@AbhiPrasad
Copy link
Member

I think we can remove it @timfish

@k-fish
Copy link
Member

k-fish commented Dec 6, 2022

Yep, let's remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants