Skip to content

fix(tracing): Deprecate and remove reportAllChanges option #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 7, 2022

Closes #6078

Removes reportAllChanges passed down through all the functions and deprecates _metricOptions since it no longer has a use.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodnight sweet prince

@AbhiPrasad
Copy link
Member

Actually, let's not deprecate _metricOptions - instead let's deprecate _reportAllChanges. #6210 will be adding a new option, so we don't want to get rid of entirely.

@timfish timfish requested a review from AbhiPrasad December 7, 2022 15:20
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 7, 2022 15:21
@AbhiPrasad AbhiPrasad disabled auto-merge December 7, 2022 15:21
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 7, 2022 15:21
@AbhiPrasad AbhiPrasad merged commit 0434474 into getsentry:master Dec 7, 2022
@timfish timfish deleted the fix/remove-reportAllChanges branch January 5, 2023 16:48
@efarem efarem mentioned this pull request Mar 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CLS metrics report does not follow options.metricOptions.reportAllChanges
2 participants