We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting an exception here: https://github.com/getsentry/raven-js/blob/master/plugins/react-native.js#L89
TypeError: undefined is not an object (evaluating 'originalCallback.call')
Adding a guard seems to resolve the problem, though I don't understand the source enough to know if that's the right solution:
Raven.setShouldSendCallback(function(data, originalCallback) { if (originalCallback && !(FATAL_ERROR_KEY in data)) { return originalCallback.call(this, data); }
The text was updated successfully, but these errors were encountered:
This code should definitely guard against originalCallback not being defined. Feeling bad I didn't notice this during review.
originalCallback
Thanks for reporting, we'll have a patch soon.
cc @nevir
Sorry, something went wrong.
shouldSendCallback
Don't assume previous shouldSendCallback exists in RN plugin (fixes #692
d356dfd
)
Doh! Sorry about that :(
bef9fa7
Don't assume previous shouldSendCallback exists in RN plugin (fixes g…
b5a199a
…etsentry#692) (getsentry#694)
No branches or pull requests
Getting an exception here: https://github.com/getsentry/raven-js/blob/master/plugins/react-native.js#L89
TypeError: undefined is not an object (evaluating 'originalCallback.call')
Adding a guard seems to resolve the problem, though I don't understand the source enough to know if that's the right solution:
The text was updated successfully, but these errors were encountered: