-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Allow to pass custom compression implementation to replay #7755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Allowing it to be treeshaken this way is a pretty substantial change - every person who is using Replay then has to go in and update their init to add this new snippet. I would rather |
So the idea is to allow to pass in an optional config, not require it. Nothing should change for existing (or new) users, unless they specifically choose to pass in a compression function. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Closing for now, as not sure if we actually need/want to provide this. It should also be OK to send stuff uncompressed, if it doesn't work any other way. |
Since #6739 is sadly not really possible due to browser constraints, another way to allow people to opt-out of the worker behavior while still having compression could be to allow passing in a custom compression implementation.
We could provide this implementation ourselves, but let it be tree shaken away if not used. This is how this could look like:
Where
getReplayEventCompressionCallback
would return a function that uses pako.The text was updated successfully, but these errors were encountered: