-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
SvelteKit SDK creates server transactions with [Method] null
name
#8199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue was extracted from a conversation in #6692. Here are some important replies:
Originally posted by @jycouet in #6692 (comment)
Originally posted by @thenbe in #6692 (comment) |
@thenbe and @jycouet RE Thanks for raising this. I believe this is a bug in the SDK because Does this match your experience/make sense to you?
I don't think we should do this if discarding sounds reasonable. The reason is that we can't parameterize the path here (i.e. determine that
So just to confirm, you get additional transactions from |
Yes, I believe that discarding will have no effect on But, in general, I'm not sure it's a good idea to see null and discard! Hope it makes sense ^^ |
Yes, I think it should still be possible to opt-in. I opened #8201 which discards transactions for unknown routes by default but makes it possible for users to opt-in. In this case we'll fall back to the raw URL path name which can still be modified by users in |
…tes (#8201) Adds a `handleUnknownRoutes` option to the `sentryHandle` server request handler. The option defaults to `false` which will effectively reduce noise, such as random bot requests. Previously such requests would yield e.g. `GET null` transactions because they could not be matched to an existing route by the framework. See #8199
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/sveltekit
SDK Version
7.53.0
Framework Version
SvelteKit 1.x
Link to Sentry event
No response
SDK Setup
Basic SDK setup from wizard
Steps to Reproduce
npm create svelte@latest
npx @sentry/wizard@latest -i sveltekit
curl localhost:PORT/something
Expected Result
Three options here:
I'm currently leaning towards option 1 because I don't see value in these transactions and it's the simplest course of action
Actual Result
The SDK sends a transaction with with a name like
GET|POST null
to Sentry, with sourceroute
This happens because we determine the txn name with
event.route.id
which evaluates tonull
.The text was updated successfully, but these errors were encountered: