Skip to content

Promote "slow clicks" to GA #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks
billyvg opened this issue Jun 6, 2023 · 1 comment · Fixed by #8298
Closed
5 tasks

Promote "slow clicks" to GA #8295

billyvg opened this issue Jun 6, 2023 · 1 comment · Fixed by #8298
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@billyvg
Copy link
Member

billyvg commented Jun 6, 2023 •
edited
Loading

Currently, slow clicks are behind an experiment. Let's:

  • Move configuration to GA
  • Increase the lower bound to start at 3 seconds (a lot of clicks happen within 250-3000 seconds that should be considered "normal")
  • Add configurable upper bound that times out at 7 seconds (backend should still consider a dead click to be 5 seconds, but let's get more data around clicks that happen between 3->7 seconds. e.g. if a button responds in the entire 3->7 range, it's likely just slow and not dead, lets figure out how many of these we have)
  • Capture disabled and aria-disabled attributes with breadcrumbs
  • Only capture interactive elements (e.g. button and a)
@billyvg billyvg added the Package: replay Issues related to the Sentry Replay SDK label Jun 6, 2023
@bruno-garcia
Copy link
Member

bruno-garcia commented Jun 6, 2023 •
edited
Loading

Part of:

@mydea mydea mentioned this issue Jun 7, 2023
Merged
mydea added a commit that referenced this issue Jun 7, 2023
@mydea
feat(replay): Capture slow clicks (GA) (#8298)
1b37517 
This moves the slow click detection out of GA and makes it generally
available. You can opt-out of this by setting `slowClickTimeout: 0`.

It also adds `disabled` & `aria-disabled` attributes to captured DOM
elements.

note: We now capture this for `<a>`, `<button>` and
`<input[type=button]>`/`<input[type=submit]>`.

Closes #8295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Capture slow clicks (GA) getsentry/sentry-javascript
2 participants
@billyvg @bruno-garcia