-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ver: 7.54.0 Cannot find module '@sentry-internal/rrweb' or its corresponding type declarations. #8326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
Same error with the newest "@sentry/angular": "7.55.0". It works OK with"@sentry/angular": "7.53.0", |
"name": "@sentry/replay",
"version": "7.55.0",
"devDependencies": {
"@babel/core": "^7.17.5",
"@sentry-internal/replay-worker": "7.55.0",
"@sentry-internal/rrweb": "1.108.0",
"@sentry-internal/rrweb-snapshot": "1.108.0",
"jsdom-worker": "^0.2.1",
"tslib": "^1.9.3"
}, |
|
Hi, thanks for reporting this. This is a bug we accidentally introduced, we thought the types would be inlined but they aren't. I am reverting this here #8329 and will cut a patch release ASAP. |
@mydea what is solution? |
for now only works with "@sentry/angular-ivy": "7.53.0", |
Hi, we just releases v7.55.1, which hopefully fixes this - can you give it a try? |
@mydea I've just tried - doesn't work - the same issue. |
@mydea before release I saw much more errors, now only two errors left: Error: node_modules/@sentry/replay/types/types/replayFrame.d.ts:1:32 - error TS2307: Cannot find module '@sentry-internal/rrweb' or its corresponding type declarations. 1 import type { EventType } from '@sentry-internal/rrweb'; Error: node_modules/@sentry/replay/types/types/rrweb.d.ts:1:32 - error TS2307: Cannot find module '@sentry-internal/rrweb' or its corresponding type declarations. 1 import type { EventType } from '@sentry-internal/rrweb'; |
As mentioned above, there is still error present. |
Damn, it seems I missed something - sorry about this! Will stamp out the remaining issues and cut another fix. |
I have a fix here, sadly I wasn't able to reproduce the issue in my test apps, so can't verify the fix actually finally fully resolves this 😬 #8334 But I hope/think it should fix it! |
|
we are having the same problem here in the company, waiting for the new release |
My test app is using latest from NPM, but it is very basic so I am not necessarily surprised it does not capture this. It's weird because we also have E2E tests in this repo checking the types, which I would have expected to catch this as well. Not sure why it isn't... |
In test app module, configure sentry and tracing and then run ng build |
|
OK, we just released 7.55.2, I tried it in your repro (thanks a lot!!) and it seems to have fixed the problem 🙏 |
|
for me it also works (we use 7.54.0) |
Is there an existing issue for this?
How do you use Sentry?
Self-hosted/on-premise
Which SDK are you using?
@sentry/angular
SDK Version
7.55.0
Framework Version
angular 16.1.0
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
Expected Result
Actual Result
node_modules/@sentry/replay/types/index.d.ts:3:27 - error TS2307: Cannot find module '@sentry-internal/rrweb' or its corresponding type declarations.
The text was updated successfully, but these errors were encountered: