Skip to content

Normalize http.response.status_code for Metrics & Alerts #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krystofwoldrich opened this issue Jun 20, 2023 · 0 comments · Fixed by #8366
Closed

Normalize http.response.status_code for Metrics & Alerts #8365

krystofwoldrich opened this issue Jun 20, 2023 · 0 comments · Fixed by #8366
Assignees

Comments

@krystofwoldrich
Copy link
Member

Problem Statement

Solution Brainstorm

Related code:

public setHttpStatus(httpStatus: number): this {
this.setTag('http.status_code', String(httpStatus));
const spanStatus = spanStatusfromHttpCode(httpStatus);
if (spanStatus !== 'unknown_error') {
this.setStatus(spanStatus);
}
return this;
}

If the http.status_code tag is removed at the same time this could be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant