Skip to content

fix(tracing-internal): Guard for missing navigation performance entries #11329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Mar 28, 2024

Ref #11326

@AbhiPrasad Do you know why we had a type-cast there?

@lforst lforst requested review from mydea, AbhiPrasad and s1gr1d March 28, 2024 08:23
Copy link

codecov bot commented Mar 28, 2024

Bundle Report

Changes will decrease total bundle size by 1.94MB ⬇️

Bundle name Size Change
@sentry-internal/tracing-cjs 108.01kB 1 bytes ⬆️
@sentry-internal/tracing-esm 107.27kB 1 bytes ⬆️
@sentry/node-experimental-cjs 157.11kB 0 bytes
@sentry/node-experimental-esm 150.43kB 0 bytes
@sentry-internal/replay-cjs 306.35kB 0 bytes
@sentry/vue-cjs 20.19kB 0 bytes
@sentry/vue-esm 18.85kB 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry-internal/replay-esm 306.46kB 0 bytes
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/gatsby-cjs 905 bytes 0 bytes
@sentry/gatsby-esm 385 bytes 0 bytes
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry-internal/replay-canvas-cjs 29.51kB 0 bytes
@sentry-internal/replay-canvas-esm 29.43kB 0 bytes
@sentry/browser-cjs 107.32kB 0 bytes
@sentry/browser-esm 104.51kB 0 bytes
@sentry/wasm-cjs 5.2kB 0 bytes
@sentry/svelte-cjs 13.84kB 0 bytes
@sentry/astro-cjs 27.13kB 0 bytes
@sentry/wasm-esm 4.85kB 0 bytes
@sentry/react-cjs 45.04kB 0 bytes
@sentry/svelte-esm 12.72kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/react-esm 41.18kB 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry/types-esm (removed) 35 bytes ⬇️
@sentry/node-esm (removed) 333.56kB ⬇️
@sentry/aws-serverless-cjs (removed) 14.62kB ⬇️
@sentry/bun-esm (removed) 10.05kB ⬇️
@sentry-internal/node-integration-tests-cjs (removed) 1.04kB ⬇️
@sentry/utils-cjs (removed) 178.75kB ⬇️
@sentry/google-cloud-serverless-cjs (removed) 23.0kB ⬇️
@sentry/utils-esm (removed) 174.17kB ⬇️
@sentry-internal/node-integration-tests-esm (removed) 888 bytes ⬇️
@sentry/core-cjs (removed) 240.46kB ⬇️
@sentry/node-cjs (removed) 336.97kB ⬇️
@sentry/google-cloud-serverless-esm (removed) 19.16kB ⬇️
@sentry/bun-cjs (removed) 13.5kB ⬇️
@sentry/profiling-node-cjs (removed) 25.5kB ⬇️
@sentry/profiling-node-esm (removed) 25.52kB ⬇️
@sentry/core-esm (removed) 236.84kB ⬇️
@sentry-internal/integration-shims-cjs (removed) 3.65kB ⬇️
@sentry/vercel-edge-cjs (removed) 18.23kB ⬇️
@sentry-internal/integration-shims-esm (removed) 2.99kB ⬇️
@sentry/vercel-edge-esm (removed) 16.13kB ⬇️
@sentry-internal/feedback-cjs (removed) 65.56kB ⬇️
@sentry/opentelemetry-cjs (removed) 68.45kB ⬇️
@sentry-internal/feedback-esm (removed) 65.28kB ⬇️
@sentry/opentelemetry-esm (removed) 67.4kB ⬇️

@mydea
Copy link
Member

mydea commented Mar 28, 2024

I think Abhi already fixed this - the PR is empty basically? :D

@lforst lforst closed this Mar 28, 2024
@lforst lforst deleted the lforst-fix-11326 branch December 3, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants