fix(node): Make fastify types more broad #11544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
stephanie-anderson and
Lms24
and removed request for
a team
size-limit report 📦
|
mydea
reviewed
Apr 11, 2024
| register: (plugin: unknown) => void; | ||
| addHook: (hook: string, handler: (request: unknown, reply: unknown, error: Error) => void) => void; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| register: (plugin: any) => void; |
There was a problem hiding this comment.
Should we make these unknown instead? That forces us to check the things, which I guess is the safer approach? 🤔
There was a problem hiding this comment.
If we use unknown the types don't line up, that's why we switched to any
see:
AbhiPrasad
force-pushed
the
abhi-fastify-ts-types
branch
from
8bf28cf to
01c4ff8
Compare
Lms24
approved these changes
Apr 12, 2024
mydea
approved these changes
Apr 12, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
As per getsentry#4784 (comment) make sure fastify types use any is that we don't collide with what fastify types expect. Also convert e2e tests to use typescript to validate build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #4784 (comment)
make sure fastify types use any is that we don't collide with what fastify types expect.
Also convert e2e tests to use typescript to validate build.