Skip to content

feat: API changes #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 3, 2018
Merged

feat: API changes #1497

merged 12 commits into from
Sep 3, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Aug 30, 2018

  • Add hint parameter for error processing
  • Remove eventprocessors from hub (now only on scope)
  • Remove shouldSend afterSend, shouldAddBreadcrumb, afterBreadcrumb

@HazAT HazAT self-assigned this Aug 30, 2018
@HazAT HazAT requested a review from kamilogorek as a code owner August 30, 2018 14:31
@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #1497 into master will decrease coverage by 0.19%.
The diff coverage is 86.02%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1497     +/-   ##
=========================================
- Coverage   72.61%   72.42%   -0.2%     
=========================================
  Files          41       41             
  Lines        1249     1262     +13     
  Branches      239      241      +2     
=========================================
+ Hits          907      914      +7     
- Misses        333      339      +6     
  Partials        9        9
Impacted Files Coverage Δ
packages/hub/src/hub.ts 98.48% <100%> (+0.12%) ⬆️
packages/hub/src/scope.ts 95.18% <100%> (ø) ⬆️
packages/core/test/mocks/backend.ts 100% <100%> (ø) ⬆️
...ages/node/src/integrations/onunhandledrejection.ts 100% <100%> (ø) ⬆️
packages/node/src/handlers.ts 21.97% <14.28%> (-0.5%) ⬇️
packages/node/src/integrations/sdkinformation.ts 88.88% <75%> (+1.38%) ⬆️
packages/node/src/backend.ts 73.91% <80%> (+1.82%) ⬆️
packages/node/src/integrations/clientoptions.ts 90.9% <85.71%> (+0.9%) ⬆️
packages/minimal/src/index.ts 95.83% <91.66%> (-4.17%) ⬇️
packages/core/src/base.ts 91.95% <95.65%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54c762...2423b24. Read the comment docs.

@HazAT HazAT changed the title [WIP] feat: API changes feat: API changes Aug 31, 2018
@HazAT HazAT merged commit f120f1a into master Sep 3, 2018
@HazAT HazAT deleted the ref/api-changes branch September 3, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants