Skip to content

fix(cjs): Use module instead of require for CJS check #15927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/node/src/utils/commonjs.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
/** Detect CommonJS. */
export function isCjs(): boolean {
return typeof require !== 'undefined';
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO if we do the try catch, we can omit the && module check xD as we should be safe already!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suuper nit xD

return typeof module !== 'undefined' && typeof module.exports !== 'undefined';
} catch {
return false;
}
}
Loading