Skip to content

feat(node): Add support for SENTRY_DEBUG env variable #15972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

feat(node): Add support for SENTRY_DEBUG env variable #15972

merged 2 commits into from
Apr 3, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 3, 2025 •
edited
Loading

Tried debugging the lambda layer today but this is super hard/impossible in a minimal setup without being able to set debug: true via env vars.

This PR:

  • sets the debug option by reading options.debug ?? process.env.SENTRY_DEBUG
  • adds unit test for a bunch of supported env variables

@Lms24 Lms24 self-assigned this Apr 3, 2025
@Lms24 Lms24 requested review from mydea and andreiborza April 3, 2025 12:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.2 KB - -
@sentry/browser - with treeshaking flags 23.02 KB - -
@sentry/browser (incl. Tracing) 36.83 KB - -
@sentry/browser (incl. Tracing, Replay) 73.99 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.39 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 78.66 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 91.22 KB - -
@sentry/browser (incl. Feedback) 40.33 KB - -
@sentry/browser (incl. sendFeedback) 27.83 KB - -
@sentry/browser (incl. FeedbackAsync) 32.63 KB - -
@sentry/react 25 KB - -
@sentry/react (incl. Tracing) 38.75 KB - -
@sentry/vue 27.41 KB - -
@sentry/vue (incl. Tracing) 38.55 KB - -
@sentry/svelte 23.23 KB - -
CDN Bundle 24.44 KB - -
CDN Bundle (incl. Tracing) 36.85 KB - -
CDN Bundle (incl. Tracing, Replay) 71.87 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.07 KB - -
CDN Bundle - uncompressed 71.24 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.94 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.23 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 232.8 KB - -
@sentry/nextjs (client) 40.06 KB +0.01% +1 B 🔺
@sentry/sveltekit (client) 37.26 KB - -
@sentry/node 142.9 KB +0.01% +12 B 🔺
@sentry/node - without tracing 96.1 KB +0.02% +12 B 🔺
@sentry/aws-serverless 120.45 KB +0.02% +17 B 🔺

View base workflow run

@Lms24 Lms24 mentioned this pull request Apr 3, 2025
Merged
@Lms24 Lms24 merged commit 35e78c6 into develop Apr 3, 2025
107 of 108 checks passed
@Lms24 Lms24 deleted the lms/feat-aws-debug branch April 3, 2025 13:30
onurtemizkan pushed a commit that referenced this pull request Apr 3, 2025
@Lms24 @onurtemizkan
feat(node): Add support for SENTRY_DEBUG env variable (#15972)
aa7c861 
- set the `debug` option by reading `options.debug ??
process.env.SENTRY_DEBUG`
- add unit test for a bunch of supported env variables
Lms24 added a commit that referenced this pull request Apr 4, 2025
@Lms24
build(aws-serverless): Include debug logs in lambda layer SDK bundle (#…
d7fbb17 
…15974)

#15972 added support for the `SENTRY_DEBUG` env variable. This patch
follows up with emitting debug logs in the minified SDK bundle we ship in 
our lambda layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@mydea mydea Awaiting requested review from mydea

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @lforst