feat(core): Move console integration into core and add to cloudflare/vercel-edge #16024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Apr 10, 2025
size-limit report 📦
|
Co-authored-by: Francesco Gringl-Novy <[email protected]>
Lms24
approved these changes
Apr 10, 2025
Comment on lines
37
to
38
| it('handles different console levels correctly', () => { | ||
| const levels = ['debug', 'info', 'warn', 'error'] as const; |
There was a problem hiding this comment.
l/nit: I'd rather use it.each so that we'd know for which specific level the test failed.
Also q: I noticed this pattern in quite a few tests (not yours, more generally in the repo) and was wondering: Am I maybe missing something why this is preferrable over it.each? 😅
Again, not a blocker, feel free to ignore
There was a problem hiding this comment.
Also q: I noticed this pattern in quite a few tests (not yours, more generally in the repo) and was wondering: Am I maybe missing something why this is preferrable over it.each? 😅
I've been leaning less toward using it.each because it's easier for me to it.only test one at a time, but I agree the table test is the better pattern here. Will change.
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15439
resolves #4532
resolves https://linear.app/getsentry/issue/JSC-192
Supercedes #16021
Our console instrumentation was always inconsistent, but adding breadcrumbs should not really be. This PR adds a unified console instrumentation to
@sentry/core, and makes the Node SDK use that. We also add this to thevercel-edgeandcloudflareSDKs.I also left todo comments in the deno and browser SDKs for us to unify into this single integration afterwards.