feat(browser): Track measure detail as span attributes #16240
Conversation
AbhiPrasad
requested review from
mydea and
andreiborza
and removed request for
a team
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
size-limit report 📦
|
| attributes[`sentry.browser.measure.detail.${key}`] = value as SpanAttributeValue; | ||
| } else { | ||
| try { | ||
| // This is user defined so we can't guarantee it's serializable |
There was a problem hiding this comment.
l: Can we instead just wrap the whole block inside of if (entry.detail) in a try-catch, maybe slightly less redundant?
There was a problem hiding this comment.
If we wrap everything in try catch it means we stop iterating through Object.entries(entry.detail), which means some valid attributes might not get serialized properly.
| // https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#detail | ||
| if (entry.detail) { | ||
| // Handle detail as an object | ||
| if (typeof entry.detail === 'object') { |
There was a problem hiding this comment.
I would also ask to support arrays of primitives, here and as object props 🙏
Listing some things in spans is very useful, and SpanAttributeValue supports this.
There was a problem hiding this comment.
We'll still handle this via serializing to JSON, so you'll get this in the UI. I'd rather not pay the bundle size cost of the extra array processing logic.
resolves #16237
The SDK automatically instruments the
performance.measureAPI, but doesn't supportdetail, which is the way you can attach arbitrary data toperformance.measure. Given you can seedetailsin browser dev-tools, we should probably support it in the same way in Sentry.https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure
detail docs: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceMeasure/detail
Detail is completely arbitrary, so we have to take care before parsing it. I have added tests accordingly.