Skip to content

fix(test): Make Remix integration tests Node 24 compatible #16241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22]
node: [18, 20, 22, 24]
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';

test('should report a manually captured error.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';

test('should report a manually captured message.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';

test('should report a manually captured message on click with the correct stacktrace.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';

test('should capture React component errors.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';

test('should report a manually created / finished transaction.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getFirstSentryEnvelopeRequest } from './utils/helpers';

test('should inject `sentry-trace` and `baggage` meta tags inside the root page.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { getFirstSentryEnvelopeRequest } from './utils/helpers';

test('should add `pageload` transaction on load.', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Page, expect, test } from '@playwright/test';
import { type Page, expect, test } from '@playwright/test';

async function getRouteData(page: Page): Promise<any> {
return page.evaluate('window.__remixContext.state.loaderData').catch(err => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Event } from '@sentry/core';
import type { Event } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import { RemixTestEnv, assertSentryEvent, assertSentryTransaction } from '../utils/helpers';

Expand Down
Loading