Skip to content

feat(react-router): Filter manifest requests #16294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function _lowQualityTransactionsFilterIntegration(options: NodeOptions): {
name: string;
processEvent: (event: Event, hint: EventHint, client: Client) => Event | null;
} {
const matchedRegexes = [/GET \/node_modules\//, /GET \/favicon\.ico/, /GET \/@id\//];
const matchedRegexes = [/GET \/node_modules\//, /GET \/favicon\.ico/, /GET \/@id\//, /GET \/__manifest\?/];

return {
name: 'LowQualityTransactionsFilter',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router/src/server/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import type { NodeClient, NodeOptions } from '@sentry/node';
import { getDefaultIntegrations as getNodeDefaultIntegrations, init as initNodeSdk } from '@sentry/node';
import { DEBUG_BUILD } from '../common/debug-build';
import { SEMANTIC_ATTRIBUTE_SENTRY_OVERWRITE } from './instrumentation/util';
import { lowQualityTransactionsFilterIntegration } from './integration/lowQualityTransactionsFilterIntegration';
import { reactRouterServerIntegration } from './integration/reactRouterServer';
import { lowQualityTransactionsFilterIntegration } from './lowQualityTransactionsFilterIntegration';

/**
* Returns the default integrations for the React Router SDK.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { Event, EventType, Integration } from '@sentry/core';
import * as SentryCore from '@sentry/core';
import * as SentryNode from '@sentry/node';
import { afterEach, describe, expect, it, vi } from 'vitest';
import { lowQualityTransactionsFilterIntegration } from '../../src/server/lowQualityTransactionsFilterIntegration';
import { lowQualityTransactionsFilterIntegration } from '../../src/server/integration/lowQualityTransactionsFilterIntegration';

const loggerLog = vi.spyOn(SentryCore.logger, 'log').mockImplementation(() => {});

Expand All @@ -18,6 +18,7 @@ describe('Low Quality Transactions Filter Integration', () => {
['node_modules requests', 'GET /node_modules/some-package/index.js'],
['favicon.ico requests', 'GET /favicon.ico'],
['@id/ requests', 'GET /@id/some-id'],
['manifest requests', 'GET /__manifest?p=%2Fperformance%2Fserver-action'],
])('%s', (description, transaction) => {
const integration = lowQualityTransactionsFilterIntegration({ debug: true }) as Integration;
const event = {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router/test/server/sdk.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { NodeClient } from '@sentry/node';
import * as SentryNode from '@sentry/node';
import { SDK_VERSION } from '@sentry/node';
import { afterEach, describe, expect, it, vi } from 'vitest';
import * as LowQualityModule from '../../src/server/lowQualityTransactionsFilterIntegration';
import * as LowQualityModule from '../../src/server/integration/lowQualityTransactionsFilterIntegration';
import { init as reactRouterInit } from '../../src/server/sdk';

const nodeInit = vi.spyOn(SentryNode, 'init');
Expand Down
Loading