Mention tags as a valid option for Raven.config
#194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked for a way to specify unchanging tags (such as git commit hash of my software), and mistakenly decided it wasn't possible to pass them to Raven.config() because the documentation enumerated various possible options but didn't mention `tags`. Bugs like getsentry#75 convinced me that this was supposed to be a supported feature. So here's a doc patch to avoid sending other users into confusion.
|
Ah. I have it documented for sending tags with each event separately: http://raven-js.readthedocs.org/en/latest/usage/index.html#passing-additional-data |
mattrobenolt
added a commit
that referenced
this pull request
Mar 26, 2014
Mention `tags` as a valid option for Raven.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked for a way to specify unchanging tags (such as git commit hash of my software), and mistakenly decided it wasn't possible to pass them to Raven.config() because the documentation enumerated various possible options but didn't mention
tags.Bugs like #75 convinced me that this was supposed to be a supported feature. So here's a doc patch to avoid sending other users into confusion.