Add auto-flushing to middleware integration #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Apr 11, 2019
packages/node/src/handlers.ts
Outdated
|
|
||
| res.end = async function end (chunk?: any, encodingOrCb?: string | Function, cb?: Function) { | ||
| await flush(2000) | ||
| console.log('flushed') |
There was a problem hiding this comment.
sorry I've already removed it
HazAT
requested changes
Apr 16, 2019
packages/node/src/handlers.ts
Outdated
| @@ -221,12 +222,21 @@ export function requestHandler(options?: { | |||
| transaction?: boolean | TransactionTypes; | |||
| user?: boolean | string[]; | |||
| version?: boolean; | |||
| wait?: boolean; | |||
There was a problem hiding this comment.
Can we make this number | undefined instead of a boolean and rename it to flushTimeout.
Also, use flushTimeout then instead of the hardcoded 2000.
There was a problem hiding this comment.
then maybe make it number and let 0 be the default which means "no flush"?
There was a problem hiding this comment.
I've updated the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per request I send PR implementing #2001
I've checked manually that it indeed flushes errors before request finishes if { wait: true } is used
Unfortunately there's no testing scaffold for existing code so it's hard for me to add new