feat: Add helper for old api to guide users to startTransaction #2625
Conversation
| * @deprecated | ||
| * We have this here as a fallback to not break users upgrading to the new API |
There was a problem hiding this comment.
Does this work in the middle of the func body? Did you mean to put if above the func signature?
There was a problem hiding this comment.
It's more a marker for us once we have a major bump to delete this block and document the breaking change.
| `Please use \`Sentry.startTransaction({name: ${(context as any).transaction}})\` to start a Transaction.`, | ||
| ); | ||
| (context as TransactionContext).name = (context as any).transaction as string; | ||
| (context as TransactionContext)._isTransaction = true; |
There was a problem hiding this comment.
I may not have fully understood this from previous PRs. What does it mean for a TransactionContext to be a Transaction (_isTransaction = true)?
There was a problem hiding this comment.
We have another safeguard using when people call
Sentry.startTransaction
Since everything goes through hub.startSpan internally with that _isTransaction we can have the check when people use JS (without types) if they forget to set the name property
No description provided.