fix(dev): Allow ember-canary to fail#3104
Merged
lobsterkatie merged 1 commit intomasterfrom Dec 8, 2020
Merged
Conversation
Contributor
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-let-ember-canary-fail
branch
from
b79df4c to
cc3c49d
Compare
kamilogorek
approved these changes
Dec 8, 2020
Member
Author
|
Going to merge w/o Travis (which is currently broken) since the GH tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a few days last week, a failure in the
ember-canarytests was blocking the rest of our CI. It seems to have resolved itself over the weekend, but as a matter of principle we probably shouldn't block on someone else's not-yet-released code. This allows theember-canarytests to fail without killing the process.(As it happens, this is even suggested in the example code in the
ember-tryREADME.)