Skip to content

fix: Replace performance.timeOrigin in favour of browserPerformanceTimeOrigin #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2021
Merged

fix: Replace performance.timeOrigin in favour of browserPerformanceTimeOrigin #3397

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbcc673
fix(webvitals): Use browserPerformanceTimeOrigin for web vitals times…
dashed Apr 15, 2021
22d4071
coerce browserPerformanceTimeOrigin as a number since it'll always be…
dashed Apr 15, 2021
c016947
replace performance.timeOrigin with browserPerformanceTimeOrigin
dashed Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/tracing/src/browser/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,13 @@ export class MetricsInstrumentation {
return;
}

const timeOrigin = msToSec(performance.timeOrigin);
const startTime = msToSec(entry.startTime as number);
logger.log('[Measurements] Adding LCP');
this._measurements['lcp'] = { value: metric.value };
this._measurements['mark.lcp'] = { value: timeOrigin + startTime };
if (browserPerformanceTimeOrigin !== undefined) {
Copy link
Contributor

@rhcarvalho rhcarvalho Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserPerformanceTimeOrigin should always exist when we can actually report LCP and FID.

I'd just replace performance.timeOrigin above with browserPerformanceTimeOrigin.

I see we use performance.timeOrigin directly in ember... maybe we change that too, cc @k-fish.

sentry-javascript/packages/ember/addon/instance-initializers/sentry-performance.ts

Line 302 in 3eb9e05

performance.measure && performance.getEntriesByName && performance.timeOrigin !== undefined;

sentry-javascript/packages/ember/addon/instance-initializers/sentry-performance.ts

Line 312 in 3eb9e05

const startTimestamp = (measure.startTime + performance.timeOrigin) / 1000;

Copy link
Member Author

@dashed dashed Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhcarvalho typescript told me that browserPerformanceTimeOrigin could be undefined, but I'll coerce it as a number

Copy link
Contributor

@rhcarvalho rhcarvalho Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah typescript... it is only undefined if performance is also undefined.

const timeOrigin = msToSec(browserPerformanceTimeOrigin);
this._measurements['mark.lcp'] = { value: timeOrigin + startTime };
}
});
}

Expand All @@ -253,11 +255,13 @@ export class MetricsInstrumentation {
return;
}

const timeOrigin = msToSec(performance.timeOrigin);
const startTime = msToSec(entry.startTime as number);
logger.log('[Measurements] Adding FID');
this._measurements['fid'] = { value: metric.value };
this._measurements['mark.fid'] = { value: timeOrigin + startTime };
if (browserPerformanceTimeOrigin !== undefined) {
const timeOrigin = msToSec(browserPerformanceTimeOrigin);
this._measurements['mark.fid'] = { value: timeOrigin + startTime };
}
});
}

Expand Down