fix(nextjs): Use domains to prevent scope bleed on backend #3574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-nextjs-no-scope-bleed
branch
from
d84a4bb to
c3e5ecc
Compare
AbhiPrasad
reviewed
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, every request to the backend was handled in the same global scope, causing all concurrent requests to share the same hub/scope/etc, with predictably bad consequences (in this case, primarily spans and errors getting associated with the wrong transactions, but the problems would extend to any data stored on the scope which is different for each request).
This PR surrounds everything in our wrapped version of the request handler in a domain, thereby isolating each request's global scope.