-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nextjs): Small integration test runner fixes #3801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lobsterkatie
merged 10 commits into
master
from
kmclb-nextjs-test-runner-fixes-july-2021
Jul 14, 2021
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
576e7b1
add missing import
lobsterkatie 5a6c884
store actual value in its own variable
lobsterkatie 759cca6
add default value to `depth` help text
lobsterkatie 0dbe33c
don't capture console breadcrumbs
lobsterkatie 1e810a0
test against correct version of nextjs
lobsterkatie 1c577aa
allow test options to be passed from bash script to js test runner
lobsterkatie 1f85890
remove superfluous reset of exit code
lobsterkatie 43357e4
remove stray logging of errorClick args
lobsterkatie 7290d76
make test filtering case-insensitive
lobsterkatie 039dfa6
use console.dir instead of inspect
lobsterkatie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,19 @@ import * as Sentry from '@sentry/nextjs'; | |
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
tracesSampleRate: 1, | ||
integrations: [ | ||
|
||
integrations: defaults => [ | ||
...defaults.filter( | ||
integration => | ||
// filter out `Console` since the tests are happening in the console and we don't need to record what's printed | ||
// there, because we can see it (this makes debug logging much less noisy, since intercepted events which are | ||
// printed to the console no longer create console breadcrumbs, which then get printed, creating even longer | ||
// console breadcrumbs, which get printed, etc, etc) | ||
|
||
// filter out `Http` so its options can be changed below (otherwise, default one wins because it's initialized first) | ||
integration.name !== 'Console' && integration.name !== 'Http', | ||
), | ||
|
||
// Used for testing http tracing | ||
new Sentry.Integrations.Http({ tracing: true }), | ||
], | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
console.dir
accept options in node api