Repository navigation
Ember | Fix TypeScript error on InitSentryForEmber - #3802
Merged
Merged
Conversation
kamilogorek
enabled auto-merge (squash)
July 13, 2021 13:38
kamilogorek
disabled auto-merge
July 13, 2021 13:38
kamilogorek
enabled auto-merge (squash)
July 13, 2021 13:39
Contributor
|
Thanks |
k-fish
approved these changes
Jul 13, 2021
k-fish
left a comment
Member
There was a problem hiding this comment.
Yep, missed that optional, thanks for the PR 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
Thank you for the hard work fixing the types publications with the Ember addon.
While testing
6.9.0, I found a new bug which was (I think) easy to address, so here is a PR for this.TypeScript is reporting the following error:
The other option is to explicitly pass
undefinedas the first argument.Let me know if there is anything else I can help with!