Handle a native angular minErr by deconstructing it #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just going to leave this here since we'd much prefer to do this inside the angular plugin, but there's not a good enough hook to do it right yet. |
| stackInfo.message = matches[2]; | ||
| // auto set a new tag specifically for the angular error url | ||
| options = options || {}; | ||
| options.tags = objectMerge({ref: matches[3]}, options.tags); |
There was a problem hiding this comment.
This should have been extra, not tags, just for future reference.
mattrobenolt
force-pushed
the
angular-eror
branch
2 times, most recently
from
885da17 to
5db0c72
Compare
|
@benvinegar Wanna take another look now? |
mattrobenolt
force-pushed
the
angular-eror
branch
from
5db0c72 to
12e631b
Compare
mattrobenolt
force-pushed
the
angular-eror
branch
from
12e631b to
fda2aa0
Compare
mattrobenolt
added a commit
that referenced
this pull request
Nov 6, 2015
Handle a native angular minErr by deconstructing it
kamilogorek
added a commit
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-243
See: https://github.com/angular/angular.js/blob/v1.4.7/src/minErr.js
One thing to note, since I'm not entirely sure what we should do, is what the value inside
[..]means.[ngPattern:noregexp]would stand forngPatternmodule, thennoregexpis the type. As seen in https://github.com/angular/angular.js/blob/d077966ff1ac18262f4615ff1a533db24d4432a7/src/ng/directive/validators.js#L37-L40So what I'm doing is completely clobbering
stackInfo.namewith thisngPattern:noregexpvalue, which hides the actualErrorconstructor type. Though, scrubbing the entire codebase of Angular, it doesn't appear that anyone leverages anything other than the defaultError. But in theory, this API exists:minErr('$foo', TypeError)and what I'm doing would clobber the fact that it was aTypeError.