feat(integrations): Make ES6 integration bundles #4718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lforst
reviewed
Mar 17, 2022
lobsterkatie
force-pushed
the
kmclb-make-es6-integration-bundles
branch
from
6eac695 to
67c62c7
Compare
lobsterkatie
force-pushed
the
kmclb-make-es6-integration-bundles
branch
from
67c62c7 to
2724c3c
Compare
lobsterkatie
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Mar 22, 2022
A number of PRs (see below) have recently added to the bundles available for use on the CDN. This documents the new options, and does some general wordsmithing on the page. Bundle-adding PRs: getsentry/sentry-javascript#4674 getsentry/sentry-javascript#4699 getsentry/sentry-javascript#4718
lobsterkatie
added a commit
that referenced
this pull request
Mar 23, 2022
In #4718, a change was made to use an environment variable to control the version of JS emitted when building integration bundles. Unfortunately, the values then given to that variable were uppercase, whereas our code assumes a lowercase version. Further, the default output is ES6 (in preparation for going ES6-first in v7), so when the version flag `ES5` doesn't match the checked-for `es5`, we emit ES6 in the supposedly-ES5 bundle. This controls for casing by casting the value to lowercase before comparison. Fixes #4768.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build config in the
integrationspackage to generate ES6 bundles as well as ES5 bundles, in preparation for going ES6-first in v7. Which JS version to build is controlled by an environment variable, in order that the builds be parallelizable.Ref: https://getsentry.atlassian.net/browse/WEB-693